citadel/heater
1
0
Fork 0
Code Issues 1 Pull Requests Projects Releases Wiki Activity

code lint

Browse Source
This commit is contained in:
Nicolas Duhamel 2022-11-02 08:21:08 +01:00
parent ee87938c93
commit d101053188
2 changed files with 91 additions and 91 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
pkg/device/device.go
View File

@ -22,11 +22,11 @@ type Error string
func (e Error) Error() string { return string(e) } func (e Error) Error() string { return string(e) }
type DeviceState struct { type DeviceState struct {
Mode string `json:"mode"` Mode string `json:"mode"`
Setpoint int `json:"setpoint"` Setpoint int `json:"setpoint"`
Time time.Time `json:"time"` Time time.Time `json:"time"`
Program_name string `json:"program_name"` ProgramName string `json:"program_name"`
UntilTime time.Time `json:"until_time"` UntilTime time.Time `json:"until_time"`
} }
func (s *DeviceState) Equivalent(state DeviceState) bool { func (s *DeviceState) Equivalent(state DeviceState) bool {
@ -54,7 +54,7 @@ func (s *DeviceState) Equivalent(state DeviceState) bool {
return false return false
} }
case "program": case "program":
if state.Program_name != s.Program_name { if state.ProgramName != s.ProgramName {
return false return false
} }
} }
@ -81,8 +81,8 @@ func (d Device) ListenTopic() (string, error) {
func (d *Device) Program() (WeekProgram, error) { func (d *Device) Program() (WeekProgram, error) {
// return current device program if specified or default one // return current device program if specified or default one
prog_name := "default" prog_name := "default"
if d.State.Program_name != "" { if d.State.ProgramName != "" {
prog_name = d.State.Program_name prog_name = d.State.ProgramName
} }
program, ok := d.Settings.Programs[prog_name] program, ok := d.Settings.Programs[prog_name]
@ -94,8 +94,8 @@ func (d *Device) Program() (WeekProgram, error) {
} }
func (d *Device) ProgramName() string { func (d *Device) ProgramName() string {
if d.State.Program_name != "" { if d.State.ProgramName != "" {
return d.State.Program_name return d.State.ProgramName
} }
return "default" return "default"
} }
@ -175,7 +175,7 @@ func (d *Device) update(log *zerolog.Logger, pubchan chan Message) (bool, error)
Int("current_setpoint", d.CurrentSetpoint). Int("current_setpoint", d.CurrentSetpoint).
Str("State.Mode", d.State.Mode). Str("State.Mode", d.State.Mode).
Int("State.Setpoint", d.State.Setpoint). Int("State.Setpoint", d.State.Setpoint).
Str("State.Program_name", d.State.Program_name). Str("State.Program_name", d.State.ProgramName).
Logger() Logger()
log.Debug().Msg("check if setpoint need an update") log.Debug().Msg("check if setpoint need an update")
@ -245,10 +245,10 @@ func (d *Device) handle_reset_state(log *zerolog.Logger, pubchan chan Message) (
} }
d.State = DeviceState{ d.State = DeviceState{
Setpoint: value, Setpoint: value,
Mode: "program", Mode: "program",
Program_name: d.ProgramName(), ProgramName: d.ProgramName(),
Time: timeNow(), Time: timeNow(),
} }
if d.CurrentSetpoint != value { if d.CurrentSetpoint != value {
@ -329,7 +329,7 @@ func (d *Device) handle_until_next(log *zerolog.Logger, pubchan chan Message) (b
} }
func (d *Device) handle_program(log *zerolog.Logger, pubchan chan Message) (bool, error) { func (d *Device) handle_program(log *zerolog.Logger, pubchan chan Message) (bool, error) {
*log = log.With().Str("program", d.State.Program_name).Logger() *log = log.With().Str("program", d.State.ProgramName).Logger()
program, err := d.Program() program, err := d.Program()
if err != nil { if err != nil {

150
pkg/device/device_test.go
View File

@ -48,10 +48,10 @@ var test_device = Device{
}, },
CurrentSetpoint: 0, CurrentSetpoint: 0,
State: DeviceState{ State: DeviceState{
Mode: "program", Mode: "program",
Setpoint: 14, Setpoint: 14,
Time: test_time, Time: test_time,
Program_name: "default", ProgramName: "default",
}, },
} }
@ -64,10 +64,10 @@ func TestStateEquivalent(t *testing.T) {
}{ }{
{ {
DeviceState{ DeviceState{
Mode: "program", Mode: "program",
Setpoint: 14, Setpoint: 14,
Time: test_time, Time: test_time,
Program_name: "default", ProgramName: "default",
}, },
DeviceState{ DeviceState{
Mode: "always", Mode: "always",
@ -78,46 +78,46 @@ func TestStateEquivalent(t *testing.T) {
}, },
{ {
DeviceState{ DeviceState{
Mode: "program", Mode: "program",
Setpoint: 14, Setpoint: 14,
Time: test_time, Time: test_time,
Program_name: "default", ProgramName: "default",
}, },
DeviceState{ DeviceState{
Mode: "program", Mode: "program",
Setpoint: 14, Setpoint: 14,
Time: test_time.Add(1 * time.Minute), Time: test_time.Add(1 * time.Minute),
Program_name: "default", ProgramName: "default",
}, },
false, false,
}, },
{ {
DeviceState{ DeviceState{
Mode: "program", Mode: "program",
Setpoint: 14, Setpoint: 14,
Time: test_time, Time: test_time,
Program_name: "default", ProgramName: "default",
}, },
DeviceState{ DeviceState{
Mode: "program", Mode: "program",
Setpoint: 13, Setpoint: 13,
Time: test_time, Time: test_time,
Program_name: "default", ProgramName: "default",
}, },
true, true,
}, },
{ {
DeviceState{ DeviceState{
Mode: "program", Mode: "program",
Setpoint: 14, Setpoint: 14,
Time: test_time, Time: test_time,
Program_name: "default", ProgramName: "default",
}, },
DeviceState{ DeviceState{
Mode: "program", Mode: "program",
Setpoint: 13, Setpoint: 13,
Time: test_time, Time: test_time,
Program_name: "other", ProgramName: "other",
}, },
false, false,
}, },
@ -128,11 +128,11 @@ func TestStateEquivalent(t *testing.T) {
Time: test_time, Time: test_time,
}, },
DeviceState{ DeviceState{
Mode: "always", Mode: "always",
Setpoint: 14, Setpoint: 14,
Time: test_time, Time: test_time,
Program_name: "other", ProgramName: "other",
UntilTime: test_time, UntilTime: test_time,
}, },
true, true,
}, },
@ -143,11 +143,11 @@ func TestStateEquivalent(t *testing.T) {
Time: test_time, Time: test_time,
}, },
DeviceState{ DeviceState{
Mode: "always", Mode: "always",
Setpoint: 15, Setpoint: 15,
Time: test_time, Time: test_time,
Program_name: "other", ProgramName: "other",
UntilTime: test_time, UntilTime: test_time,
}, },
false, false,
}, },
@ -158,11 +158,11 @@ func TestStateEquivalent(t *testing.T) {
Time: test_time, Time: test_time,
}, },
DeviceState{ DeviceState{
Mode: "until_next", Mode: "until_next",
Setpoint: 14, Setpoint: 14,
Time: test_time, Time: test_time,
Program_name: "other", ProgramName: "other",
UntilTime: test_time, UntilTime: test_time,
}, },
true, true,
}, },
@ -173,11 +173,11 @@ func TestStateEquivalent(t *testing.T) {
Time: test_time, Time: test_time,
}, },
DeviceState{ DeviceState{
Mode: "until_next", Mode: "until_next",
Setpoint: 13, Setpoint: 13,
Time: test_time, Time: test_time,
Program_name: "other", ProgramName: "other",
UntilTime: test_time, UntilTime: test_time,
}, },
false, false,
}, },
@ -189,11 +189,11 @@ func TestStateEquivalent(t *testing.T) {
UntilTime: test_time.Add(1 * time.Hour), UntilTime: test_time.Add(1 * time.Hour),
}, },
DeviceState{ DeviceState{
Mode: "until_time", Mode: "until_time",
Setpoint: 14, Setpoint: 14,
Time: test_time, Time: test_time,
Program_name: "other", ProgramName: "other",
UntilTime: test_time.Add(1 * time.Hour), UntilTime: test_time.Add(1 * time.Hour),
}, },
true, true,
}, },
@ -205,11 +205,11 @@ func TestStateEquivalent(t *testing.T) {
UntilTime: test_time.Add(1 * time.Hour), UntilTime: test_time.Add(1 * time.Hour),
}, },
DeviceState{ DeviceState{
Mode: "until_time", Mode: "until_time",
Setpoint: 13, Setpoint: 13,
Time: test_time, Time: test_time,
Program_name: "other", ProgramName: "other",
UntilTime: test_time.Add(1 * time.Hour), UntilTime: test_time.Add(1 * time.Hour),
}, },
false, false,
}, },
@ -221,11 +221,11 @@ func TestStateEquivalent(t *testing.T) {
UntilTime: test_time.Add(1 * time.Hour), UntilTime: test_time.Add(1 * time.Hour),
}, },
DeviceState{ DeviceState{
Mode: "until_time", Mode: "until_time",
Setpoint: 14, Setpoint: 14,
Time: test_time, Time: test_time,
Program_name: "other", ProgramName: "other",
UntilTime: test_time.Add(2 * time.Hour), UntilTime: test_time.Add(2 * time.Hour),
}, },
false, false,
}, },
@ -262,7 +262,7 @@ func TestListenTopic(t *testing.T) {
func TestProgram(t *testing.T) { func TestProgram(t *testing.T) {
//case 1: no program set in state return default //case 1: no program set in state return default
case1_device := test_device case1_device := test_device
case1_device.State.Program_name = "" case1_device.State.ProgramName = ""
//case 2: program set "confort" must return it //case 2: program set "confort" must return it
var test_confort_weekprogram = WeekProgram{ var test_confort_weekprogram = WeekProgram{
@ -279,11 +279,11 @@ func TestProgram(t *testing.T) {
"default": test_weekprogram, "default": test_weekprogram,
"confort": test_confort_weekprogram, "confort": test_confort_weekprogram,
} }
case2_device.State.Program_name = "confort" case2_device.State.ProgramName = "confort"
//case 3: program set "confort" but not exist //case 3: program set "confort" but not exist
case3_device := test_device case3_device := test_device
case3_device.State.Program_name = "confort" case3_device.State.ProgramName = "confort"
var tests = []struct { var tests = []struct {
name string name string
@ -324,15 +324,15 @@ func TestUpdate(t *testing.T) {
device1 := test_device device1 := test_device
device1.Name = "1" device1.Name = "1"
device1.State = DeviceState{ device1.State = DeviceState{
Mode: "program", Mode: "program",
Setpoint: 0, Setpoint: 0,
Time: test_time, Time: test_time,
Program_name: "", ProgramName: "",
} }
device2 := test_device device2 := test_device
device2.Name = "2" device2.Name = "2"
device2.State.Program_name = "unknown" device2.State.ProgramName = "unknown"
device3 := test_device device3 := test_device
device3.Name = "3" device3.Name = "3"