Add better alerts for ok / error messages

This commit is contained in:
Grégoire Delattre 2017-01-18 21:17:07 +01:00
parent 2082fac21c
commit b9b1fb356f
11 changed files with 91 additions and 46 deletions

View File

@ -15,6 +15,7 @@
"jwt-decode": "^2.1.0", "jwt-decode": "^2.1.0",
"react": "^15.3.2", "react": "^15.3.2",
"react-bootstrap": "^0.30.6", "react-bootstrap": "^0.30.6",
"react-bootstrap-sweetalert": "^3.0.0",
"react-dom": "^15.3.2", "react-dom": "^15.3.2",
"react-loading": "^0.0.9", "react-loading": "^0.0.9",
"react-redux": "^4.4.6", "react-redux": "^4.4.6",

View File

@ -1,21 +1,30 @@
import { configureAxios, request } from '../requests' import { configureAxios, request } from '../requests'
// ====================== // ======================
// Errors // Alerts
// ====================== // ======================
export function addError(message) { export function addAlertError(message) {
return { return {
type: 'ADD_ERROR', type: 'ADD_ALERT_ERROR',
payload: { payload: {
message, message,
} }
} }
} }
export function dismissError() { export function addAlertOk(message) {
return { return {
type: 'DISMISS_ERROR', type: 'ADD_ALERT_OK',
payload: {
message,
}
}
}
export function dismissAlert() {
return {
type: 'DISMISS_ALERT',
} }
} }
@ -44,14 +53,15 @@ export function loginUser(username, password) {
username: username, username: username,
password: password, password: password,
}, },
) ),
) )
} }
export function updateUser(config) { export function updateUser(config) {
return request( return request(
'USER_UPDATE', 'USER_UPDATE',
configureAxios().post('/users/edit', config) configureAxios().post('/users/edit', config),
"User updated",
) )
} }

View File

@ -27,7 +27,7 @@ import store, { history } from './store'
// Components // Components
import NavBar from './components/navbar' import NavBar from './components/navbar'
import Error from './components/errors' import Alert from './components/alerts/alert'
import MovieList from './components/movies/list' import MovieList from './components/movies/list'
import ShowList from './components/shows/list' import ShowList from './components/shows/list'
import ShowDetails from './components/shows/details' import ShowDetails from './components/shows/details'
@ -43,7 +43,7 @@ class Main extends React.Component {
return ( return (
<div> <div>
<NavBar {...this.props}/> <NavBar {...this.props}/>
<Error {...this.props}/> <Alert {...this.props}/>
<div className="container-fluid"> <div className="container-fluid">
{React.cloneElement(this.props.children, this.props)} {React.cloneElement(this.props.children, this.props)}
</div> </div>
@ -57,7 +57,7 @@ function mapStateToProps(state) {
movieStore: state.movieStore, movieStore: state.movieStore,
showStore: state.showStore, showStore: state.showStore,
userStore: state.userStore, userStore: state.userStore,
errors: state.errors, alerts: state.alerts,
} }
} }

View File

@ -0,0 +1,17 @@
import React from 'react'
import SweetAlert from 'react-bootstrap-sweetalert';
export default function Alert(props) {
if (!props.alerts.show) {
return null
}
return (
<SweetAlert
type={props.alerts.type}
onConfirm={props.dismissAlert}
title={props.alerts.message}
/>
)
}

View File

@ -1,19 +0,0 @@
import React from 'react'
export default function Error(props) {
if (!props.errors.message) {
return null
}
return (
<div className="row">
<div className="col-md-6 col-md-offset-3 col-xs-12">
<div className="alert alert-warning">
<button type="button" className="close" onClick={props.dismissError}>
<span>&times;</span>
</button>
<p>{props.errors.message}</p>
</div>
</div>
</div>
)
}

View File

@ -0,0 +1,30 @@
const defaultState = {
show: false,
message: "",
type: "",
};
export default function Alert(state = defaultState, action) {
switch (action.type) {
case 'ADD_ALERT_ERROR':
return Object.assign({}, state, {
message: action.payload.message,
show: true,
type: "error",
})
case 'ADD_ALERT_OK':
return Object.assign({}, state, {
message: action.payload.message,
show: true,
type: "success",
})
case 'DISMISS_ALERT':
return Object.assign({}, state, {
message: "",
show: false,
type: "",
})
default:
return state;
}
}

View File

@ -1,12 +0,0 @@
export default function error(state = {}, action) {
switch (action.type) {
case 'ADD_ERROR':
return Object.assign({}, state, {
message: action.payload.message,
})
case 'DISMISS_ERROR':
return {};
default:
return state;
}
}

View File

@ -4,7 +4,7 @@ import { routerReducer } from 'react-router-redux'
import movieStore from './movies' import movieStore from './movies'
import showStore from './shows' import showStore from './shows'
import userStore from './users' import userStore from './users'
import errors from './errors' import alerts from './alerts'
// Use combine form form react-redux-form, it's a thin wrapper arround the // Use combine form form react-redux-form, it's a thin wrapper arround the
// default combinedReducers provided with React. It allows the forms to be // default combinedReducers provided with React. It allows the forms to be
@ -14,7 +14,7 @@ const rootReducer = combineForms({
movieStore, movieStore,
showStore, showStore,
userStore, userStore,
errors, alerts,
}) })
export default rootReducer; export default rootReducer;

View File

@ -16,7 +16,7 @@ export function configureAxios(headers = {}) {
// This function takes en event prefix to dispatch evens during the life of the // This function takes en event prefix to dispatch evens during the life of the
// request, it also take a promise (axios request) // request, it also take a promise (axios request)
export function request(eventPrefix, promise) { export function request(eventPrefix, promise, successMessage = null) {
// Events // Events
const pending = `${eventPrefix}_PENDING`; const pending = `${eventPrefix}_PENDING`;
const fulfilled = `${eventPrefix}_FULFILLED`; const fulfilled = `${eventPrefix}_FULFILLED`;
@ -30,7 +30,7 @@ export function request(eventPrefix, promise) {
if (response.data.status === 'error') if (response.data.status === 'error')
{ {
dispatch({ dispatch({
type: 'ADD_ERROR', type: 'ADD_ALERT_ERROR',
payload: { payload: {
message: response.data.message, message: response.data.message,
} }
@ -40,6 +40,14 @@ export function request(eventPrefix, promise) {
type: fulfilled, type: fulfilled,
payload: response.data, payload: response.data,
}) })
if (successMessage) {
dispatch({
type: 'ADD_ALERT_OK',
payload: {
message: successMessage,
},
})
}
}) })
.catch(error => { .catch(error => {
// Unauthorized // Unauthorized
@ -49,7 +57,7 @@ export function request(eventPrefix, promise) {
}) })
} }
dispatch({ dispatch({
type: 'ADD_ERROR', type: 'ADD_ALERT_ERROR',
payload: { payload: {
message: error.response.data, message: error.response.data,
} }

View File

@ -42,3 +42,7 @@ body {
.navbar { .navbar {
opacity: 0.95; opacity: 0.95;
} }
div.sweet-alert > h2 {
color: @body-bg;
}

View File

@ -3077,6 +3077,12 @@ react-bootstrap:
uncontrollable "^4.0.1" uncontrollable "^4.0.1"
warning "^3.0.0" warning "^3.0.0"
react-bootstrap-sweetalert:
version "3.0.0"
resolved "https://registry.yarnpkg.com/react-bootstrap-sweetalert/-/react-bootstrap-sweetalert-3.0.0.tgz#65378a42f37845676acf98e8c43ce4a61f23306f"
dependencies:
object-assign "^4.1.0"
react-dom@^15.3.2: react-dom@^15.3.2:
version "15.3.2" version "15.3.2"
resolved "https://registry.yarnpkg.com/react-dom/-/react-dom-15.3.2.tgz#c46b0aa5380d7b838e7a59c4a7beff2ed315531f" resolved "https://registry.yarnpkg.com/react-dom/-/react-dom-15.3.2.tgz#c46b0aa5380d7b838e7a59c4a7beff2ed315531f"